[Mlir-commits] [mlir] [mlir][bufferization] OwnershipBasedBufferDeallocation fixes (PR #67418)

Ivan Butygin llvmlistbot at llvm.org
Tue Sep 26 05:02:56 PDT 2023


================
@@ -931,8 +935,10 @@ BufferDeallocation::handleInterface(RegionBranchTerminatorOpInterface op) {
 
 bool BufferDeallocation::isFunctionWithoutDynamicOwnership(Operation *op) {
   auto funcOp = dyn_cast<FunctionOpInterface>(op);
-  return funcOp && (!options.privateFuncDynamicOwnership ||
-                    funcOp.getVisibility() != SymbolTable::Visibility::Private);
+  return funcOp &&
+         (!options.privateFuncDynamicOwnership ||
+          funcOp.getVisibility() != SymbolTable::Visibility::Private ||
----------------
Hardcode84 wrote:

nit: `FuncOp` has `isPrivate()` which is doing exactly that

https://github.com/llvm/llvm-project/pull/67418


More information about the Mlir-commits mailing list