[Mlir-commits] [mlir] Add a structured if operation (PR #67234)

Gil Rapaport llvmlistbot at llvm.org
Tue Sep 26 02:01:54 PDT 2023


aniragil wrote:

> Had a chance to take a short look (expect for the conversion). Overall looks good to me. One thing I noticed is that `auto`is used quite often, while the LLVM guidelines ask for a more moderate use, see https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable and https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto.

Indeed ... fixing.

> 
> Furthermore, you could delete
> 
> https://github.com/llvm/llvm-project/blob/d3505c28a770fabd77d7483afbca383d453bef02/mlir/docs/Dialects/emitc.md?plain=1#L36
> .

Ah, missed the doc. Done.

Thanks Marius!

https://github.com/llvm/llvm-project/pull/67234


More information about the Mlir-commits mailing list