[Mlir-commits] [mlir] [MLIR][LLVM] Add vararg support in LLVM::LLVMFuncOp (PR #67274)

Tobias Gysi llvmlistbot at llvm.org
Tue Sep 26 00:16:02 PDT 2023


https://github.com/gysit commented:

I like the changes you did to the printer and parser :).

Can you add some more tests? I think it would make sense to have a roundtrip test to check the printing and parsing in mlir/test/Dialect/LLVMIR/func.mlir. Additionally, there should be a test that the translation to LLVM IR works as well.

https://github.com/llvm/llvm-project/pull/67274


More information about the Mlir-commits mailing list