[Mlir-commits] [mlir] [mlir] Add loaded URI attribute type (PR #67276)

[Mehdi Amini]

https://github.com/joker-eph requested changes to this pull request.

It's not clear to me that this should be a builtin here: seems a bit quite specific?

Also the current implementation only support one scheme, the "URL" is implicitly a file path apparently, and it's eagerly loaded. Adding more scheme seems necessarily intrusive here (you have to modify the builtin dialect): there does not seem to be any dialect-customization available.

I am wondering if the value here isn't in the mechanic more than the attribute itself: that is we could just provide the facilities for dialect to have this behavior easily, without providing an actual attribute?


https://github.com/llvm/llvm-project/pull/67276