[Mlir-commits] [mlir] Add a structured if operation (PR #67234)

Marius Brehler llvmlistbot at llvm.org
Mon Sep 25 13:26:15 PDT 2023


https://github.com/marbre commented:

Had a chance to take a short look (expect for the conversion). Overall looks good to me. One thing I noticed is that `auto`is used quite often, while the LLVM guidelines ask for a more moderate use, see https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable and https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto.

https://github.com/llvm/llvm-project/pull/67234


More information about the Mlir-commits mailing list