[Mlir-commits] [mlir] [MLIR][Presburger] Make IntegerRelation::convertVarKind consistent wi… (PR #67323)

[Kunwar Grover]

================
@@ -545,20 +545,19 @@ class IntegerRelation {
 
   void removeDuplicateDivs();
 
-  /// Converts variables of kind srcKind in the range [varStart, varLimit) to
-  /// variables of kind dstKind. If `pos` is given, the variables are placed at
-  /// position `pos` of dstKind, otherwise they are placed after all the other
-  /// variables of kind dstKind. The internal ordering among the moved variables
-  /// is preserved.
-  void convertVarKind(VarKind srcKind, unsigned varStart, unsigned varLimit,
-                      VarKind dstKind, unsigned pos);
-  void convertVarKind(VarKind srcKind, unsigned varStart, unsigned varLimit,
+  /// Converts variables of the specified kind in the column range [srcPos,
+  /// srcPos + num) to variables of the specified kind at position dstPos. The
+  /// ranges are relative to the kind of variable.
+  ///
+  /// srcKind and dstKind must be different.
+  void convertVarKind(VarKind srcKind, unsigned srcPos, unsigned num,
+                      VarKind dstKind, unsigned dstPos);
----------------
Groverkss wrote:

Please specify what happens when dstPos is not given.

https://github.com/llvm/llvm-project/pull/67323