[Mlir-commits] [mlir] [MLIR][LLVM] Add vararg support in LLVM::LLVMFuncOp (PR #67274)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Mon Sep 25 02:20:51 PDT 2023


================
@@ -950,6 +950,16 @@ static void printStoreType(OpAsmPrinter &printer, Operation *op,
 // CallOp
 //===----------------------------------------------------------------------===//
 
+namespace {
+static TypeRange getCallOpResults(LLVMFunctionType calleeType) {
----------------
ftynse wrote:

Either anonymous namespace or `static` is enough for functions. MLIR prefers `static`.

Also please document top-level entities.

https://github.com/llvm/llvm-project/pull/67274


More information about the Mlir-commits mailing list