[Mlir-commits] [mlir] [MLIR][LLVM] Add vararg support in LLVM::LLVMFuncOp (PR #67274)

[Tobias Gysi]

https://github.com/gysit commented:

Thanks for working on this.

I think personally I would put the vararg type after the arguments:
```
%2 = llvm.call @printf(%1, %arg0) vararg(!llvm.func<i32 (ptr<4>, ...)>) : (!llvm.ptr<4>, i32) -> i32
```
and wrap it into parentheses to emphasis stuff that is connected. The main advantage of this syntax is that the callee symbol and its arguments remain closely connected. What do you think? 

Overall this is mostly a matter of taste though.


https://github.com/llvm/llvm-project/pull/67274