[Mlir-commits] [mlir] [MLIR] When generating tests explicitly match only valid SSA var names (PR #67279)

[Oleksandr Alex Zinenko]

================
@@ -180,7 +180,7 @@ def process_line(line_chunks, variable_namer):
         else:
             # Otherwise, generate a new variable.
             variable = variable_namer.generate_name(ssa_name)
-            output_line += "%[[" + variable + ":.*]]"
+            output_line += "%[[" + variable + ":" + SSA_RE_STR + "]]"
----------------
ftynse wrote:

In this case, I'd try looking specifically for the pattern that appears in function arguments somehow. E.g., check if two chunks starting at `%` have a common prefix that consists of the SSA name followed by something else. In that case, we could insert the more verbose regexp. This could be beneficial to more cases than just functions with memrefs.

https://github.com/llvm/llvm-project/pull/67279