[Mlir-commits] [mlir] [MLIR] When generating tests explicitly match only valid SSA var names (PR #67279)

Ivan R. Ivanov llvmlistbot at llvm.org
Mon Sep 25 01:12:28 PDT 2023


================
@@ -180,7 +180,7 @@ def process_line(line_chunks, variable_namer):
         else:
             # Otherwise, generate a new variable.
             variable = variable_namer.generate_name(ssa_name)
-            output_line += "%[[" + variable + ":.*]]"
+            output_line += "%[[" + variable + ":" + SSA_RE_STR + "]]"
----------------
ivanradanov wrote:

It happens at each function definition where there are multiple memref arguments of the same type.

I am fine with keeping it as is, you are right that the tests become hard to read due to this. I will close this for now and might reopen if I think of a better option. 

https://github.com/llvm/llvm-project/pull/67279


More information about the Mlir-commits mailing list