[Mlir-commits] [mlir] [mlir][ArmSME] Add `enable_arm_streaming_ignore` attribute (PR #66911)

[Andrzej Warzyński]

================
@@ -9,3 +9,11 @@
 // CHECK-ENABLE-ZA-LABEL: @arm_streaming
 // CHECK-ENABLE-ZA-SAME: attributes {arm_streaming, arm_za}
 func.func @arm_streaming() { return }
+
+// CHECK-LABEL: @not_arm_streaming
+// CHECK-SAME: attributes {enable_arm_streaming_ignore}
+// CHECK-LOCALLY-LABEL: @not_arm_streaming
+// CHECK-LOCALLY-SAME: attributes {enable_arm_streaming_ignore}
+// CHECK-ENABLE-ZA-LABEL: @not_arm_streaming
+// CHECK-ENABLE-ZA-SAME: attributes {enable_arm_streaming_ignore}
----------------
banach-space wrote:

The way this is written now, I think that you could have the following output and the test would pass (which is not what we want):

```
func.func @not_arm_streaming() attributes {enable_arm_streaming_ignore, arm_locally_streaming} { return }
```

So you'd need this to be 100% sure:
```
// CHECK-LABEL: @not_arm_streaming
// CHECK-NOT: arm_streaming
// CHECK-LOCALLY-LABEL: @not_arm_streaming
// CHECK-NOT: arm_streaming
```

This should be sufficient though:
```
// CHECK-LABEL: @not_arm_streaming
// CHECK-NOT: arm_streaming
```
This way, you match the label (which is unique) and the make sure that there's no `arm_streaming` attribute starting from the label all the way to EOF.

https://github.com/llvm/llvm-project/pull/66911