[Mlir-commits] [mlir] [mlir][transform] Improve error message of tracking listener. (PR #66987)
Ingo Müller
llvmlistbot at llvm.org
Thu Sep 21 06:08:08 PDT 2023
================
@@ -1444,16 +1443,20 @@ bool transform::ErrorCheckingTrackingListener::failed() const {
}
void transform::ErrorCheckingTrackingListener::notifyPayloadReplacementNotFound(
- Operation *op, ValueRange values) {
+ Operation *op, ValueRange values, ArrayRef<Operation *> aliveUsers) {
if (status.succeeded()) {
status = emitSilenceableFailure(
- getTransformOp(), "tracking listener failed to find replacement op");
+ getTransformOp(), "op was replaced but replacement was of different "
+ "kind, invalidating alive handles");
----------------
ingomueller-net wrote:
I talked a bit with Matthias about this aspect. Indeed, there are a couple of options. The next revision returns a `DiagnosedSilenceableFailure` and passes the result `Operation*` through an output argument. Let me know if you prefer one of the other options.
https://github.com/llvm/llvm-project/pull/66987
More information about the Mlir-commits
mailing list