[Mlir-commits] [mlir] [mlir] Fix some cmake dependencies in LLVMIR Dialect (PR #66956)

Fabian Mora llvmlistbot at llvm.org
Thu Sep 21 04:55:10 PDT 2023


Markus =?utf-8?q?Böck?= <markus.bock+llvm at nextsilicon.com>
Message-ID:
In-Reply-To: <llvm/llvm-project/pull/66956/mlir at github.com>


https://github.com/fabianmcg approved this pull request.

You're right it's only needed for the promise, could you also remove `#include "mlir/Dialect/GPU/IR/CompilationInterfaces.h"` from `include/mlir/Dialect/LLVMIR/(NVVM|ROCDL)Dialect.h` so they don't inadvertently pollute other files.  Thank you for catching these.

https://github.com/llvm/llvm-project/pull/66956


More information about the Mlir-commits mailing list