[Mlir-commits] [mlir] [mlir][transform] Improve error message of tracking listener. (PR #66987)

[Matthias Springer]

================
@@ -1444,16 +1443,20 @@ bool transform::ErrorCheckingTrackingListener::failed() const {
 }
 
 void transform::ErrorCheckingTrackingListener::notifyPayloadReplacementNotFound(
-    Operation *op, ValueRange values) {
+    Operation *op, ValueRange values, ArrayRef<Operation *> aliveUsers) {
   if (status.succeeded()) {
     status = emitSilenceableFailure(
-        getTransformOp(), "tracking listener failed to find replacement op");
----------------
matthias-springer wrote:

maybe "tracking listener failed to find replacement op for op that is tracked by non-dead handle".

But even that could be confusion. Maybe we should just add a comment in the C++ code that mentions all the conditions (type changed, handle not dead, etc.).


https://github.com/llvm/llvm-project/pull/66987