[Mlir-commits] [mlir] [mlir][ArmSME] Add support for vector.transpose (PR #66760)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Wed Sep 20 00:41:15 PDT 2023
================
----------------
banach-space wrote:
To me it would make sense to merge this with [test-load-vertical.mlir](https://github.com/llvm/llvm-project/pull/66760/commits/463c7c24d4c7ccb5237829b492d1f1a0ff3ea6e2#diff-c4896a180fa4b589bfc06b68f1ba5a74871c3cdfd9b2177fe6eefcc8d8823746) and have 2 `RUN` lines with different entry points.
In principle, both end-to-end tests verify matrix transposition. And there's a lot of code duplication. Also, for end-to-end tests, I think that it would be nice to converge towards testing higher-level operations (e.g. matmul or conv).
If you do decide to merge it, you could keep this name to indicate that this is indeed matrix transposition.
https://github.com/llvm/llvm-project/pull/66760
More information about the Mlir-commits
mailing list