[Mlir-commits] [mlir] [mlir][memref][transform] Add new alloca_to_global op. (PR #66511)

[Ingo Müller]

ingomueller-net wrote:

> I am not sure whether the `module` argument is really necessary. I do need access to the surrounding module to insert the `memref.global`s, but I can do that through code (with `getParentOfType`). Also, I leave the module itself (and all other ops exact for the `alloca` inputs) intact and only add new ones.
> 
> I had an original version with that argument and that ran, except for some crashes that I retrospectively relate to #66357. It may, thus, work without the argument but is it legal to do so?

@ftynse: Can you help us with this? @nicolasvasilache and @matthias-springer seemed to say that this might be safe but weren't very confident in their assessment...

https://github.com/llvm/llvm-project/pull/66511