[Mlir-commits] [mlir] [MLIR][Presburger] Template Matrix to allow MPInt and Fraction (PR #65272)

Arjun P llvmlistbot at llvm.org
Mon Sep 18 08:12:12 PDT 2023


================
@@ -32,7 +34,10 @@ namespace presburger {
 /// (i, j) is stored at data[i*nReservedColumns + j]. The reserved but unused
 /// columns always have all zero values. The reserved rows are just reserved
 /// space in the underlying SmallVector's capacity.
+template<typename T>
----------------
Superty wrote:

Can you mention here that the class only works for types MPInt and Fraction as the implementations are left in a separate .cpp file and only these two types have been explicitly instantiated there. You can drop the comment on line 39 below

https://github.com/llvm/llvm-project/pull/65272


More information about the Mlir-commits mailing list