[Mlir-commits] [mlir] [mlir][llvm] Use zeroinitializer for TargetExtType (PR #66510)

[Lukas Sommer]

sommerlukas wrote:

> Very happy to see this being cleaned up!

Thanks for your feedback @zero9178!

> I was initially surprised that this PR did not require any changes in the export and checked the original revision again. It added code specifically for initializing target extension types here: https://github.com/llvm/llvm-project/blob/main/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp#L347-L356 Can this be removed now?
> 
> I see that the export logic is already implemented in `llvm.mlir.zero` op.

Good catch, I removed that from `ModuleTranslation.cpp`. 

https://github.com/llvm/llvm-project/pull/66510