[Mlir-commits] [mlir] [MLIR] Allow comparison of opaque properties (PR #66378)

[Mehdi Amini]

================
@@ -768,7 +768,9 @@ OperationEquivalence::isRegionEquivalentTo(Region *lhs, Region *rhs,
       lhs->getNumSuccessors() != rhs->getNumSuccessors() ||
       lhs->getNumOperands() != rhs->getNumOperands() ||
       lhs->getNumResults() != rhs->getNumResults() ||
-      lhs->hashProperties() != rhs->hashProperties())
+      lhs->hashProperties() != rhs->hashProperties() ||
+      !lhs->getName().compareOpProperties(lhs->getPropertiesStorage(),
+                                        rhs->getPropertiesStorage()))
----------------
joker-eph wrote:

I'm actually wondering if hashing isn't even more costly than the comparison somehow, wonder if we should drop the hash comparison here?

https://github.com/llvm/llvm-project/pull/66378