[Mlir-commits] [mlir] [mlir][llvm] Use zeroinitializer for TargetExtType (PR #66510)

Markus Böck llvmlistbot at llvm.org
Fri Sep 15 14:12:04 PDT 2023


zero9178 wrote:

Very happy to see this being cleaned up!

I was initially surprised that this PR did not require any changes in the export and checked the original revision again. It added code specifically for initializing target extension types here: 
https://github.com/llvm/llvm-project/blob/main/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp#L347-L356
Can this be removed now?

I see that the export logic is already implemented in `llvm.mlir.zero` op.

https://github.com/llvm/llvm-project/pull/66510


More information about the Mlir-commits mailing list