[Mlir-commits] [mlir] [mlir][IR] SingleBlockImplicitTerminator derives from TraitBase (PR #66189)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Sep 13 03:21:49 PDT 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-core
            
<details>
<summary>Changes</summary>
This was an oversight in 0ac21e654f194a0f7c9f5afe42e11924c546f89e.
--
Full diff: https://github.com/llvm/llvm-project/pull/66189.diff

1 Files Affected:

- (modified) mlir/include/mlir/IR/OpDefinition.h (+2-1) 


<pre>
diff --git a/mlir/include/mlir/IR/OpDefinition.h b/mlir/include/mlir/IR/OpDefinition.h
index 67d923adbf9374b..0fe53e7aa7b11c6 100644
--- a/mlir/include/mlir/IR/OpDefinition.h
+++ b/mlir/include/mlir/IR/OpDefinition.h
@@ -943,7 +943,8 @@ struct SingleBlock : public TraitBase<ConcreteType, SingleBlock> {
 template <typename TerminatorOpType>
 struct SingleBlockImplicitTerminator {
   template <typename ConcreteType>
-  class Impl {
+  class Impl : public TraitBase<ConcreteType, SingleBlockImplicitTerminator<
+                                                  TerminatorOpType>::Impl> {
   private:
     /// Builds a terminator operation without relying on OpBuilder APIs to avoid
     /// cyclic header inclusion.
</pre>
</details>


https://github.com/llvm/llvm-project/pull/66189


More information about the Mlir-commits mailing list