[Mlir-commits] [mlir] [mlir][IR] SingleBlockImplicitTerminator derives from TraitBase (PR #66189)

Matthias Springer llvmlistbot at llvm.org
Wed Sep 13 03:20:50 PDT 2023


https://github.com/matthias-springer created https://github.com/llvm/llvm-project/pull/66189:

This was an oversight in 0ac21e654f194a0f7c9f5afe42e11924c546f89e.

>From e2176d9c2a88cf0095b094fb35167ab03a148334 Mon Sep 17 00:00:00 2001
From: Matthias Springer <me at m-sp.org>
Date: Wed, 13 Sep 2023 12:19:40 +0200
Subject: [PATCH] [mlir][IR] SingleBlockImplicitTerminator derives from
 TraitBase

This was an oversight in 0ac21e654f194a0f7c9f5afe42e11924c546f89e.
---
 mlir/include/mlir/IR/OpDefinition.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mlir/include/mlir/IR/OpDefinition.h b/mlir/include/mlir/IR/OpDefinition.h
index 67d923adbf9374b..0fe53e7aa7b11c6 100644
--- a/mlir/include/mlir/IR/OpDefinition.h
+++ b/mlir/include/mlir/IR/OpDefinition.h
@@ -943,7 +943,8 @@ struct SingleBlock : public TraitBase<ConcreteType, SingleBlock> {
 template <typename TerminatorOpType>
 struct SingleBlockImplicitTerminator {
   template <typename ConcreteType>
-  class Impl {
+  class Impl : public TraitBase<ConcreteType, SingleBlockImplicitTerminator<
+                                                  TerminatorOpType>::Impl> {
   private:
     /// Builds a terminator operation without relying on OpBuilder APIs to avoid
     /// cyclic header inclusion.



More information about the Mlir-commits mailing list