[Mlir-commits] [mlir] [mlir][spirv] Fix coop matrix load (PR #65712)

[Jakub Kuderski]

kuhar wrote:

> Looking at the spec the stride seems to be optional: https://htmlpreview.github.io/?https://github.com/KhronosGroup/SPIRV-Registry/blob/master/extensions/KHR/SPV_KHR_cooperative_matrix.html unless I am misinterpreting it. Should we try to match the optionality in the spec here?

Matching this two-level optionality (operand and attribute) is not possible without changes on the tablegen side (https://github.com/llvm/llvm-project/blob/8669a9f93adb2d3d3ca44a0b0873000927762177/mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp#L931-L935). Would be nice to have so that we can deserialize SPIR-V blobs that rely on this, but I think having it as non-optional simplifies things.

https://github.com/llvm/llvm-project/pull/65712