[Mlir-commits] [mlir] [mlir] Add option to add comdat to all linkonce functions (PR #65270)

[David Truby]

DavidTruby wrote:

I'm not really sure this is the best way to do it in general, I wanted to post for comments really. I think a linkage-like comdat attribute on FuncOp would possibly be better in the long run so that languages/conversions that need this behaviour can add it granularly, although we may still want the option to add it for everything for users that don't care and just want linking to work. 

Doing it like this does fix our use case in flang, as we would be one of the aforementioned non-bothered users :)

https://github.com/llvm/llvm-project/pull/65270