[Mlir-commits] [mlir] ef6014e - [MLIR][LaunchFuncToLLVM] Remove typed pointer support (#70840)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Tue Oct 31 15:02:59 PDT 2023
Author: Christian Ulmann
Date: 2023-10-31T23:02:55+01:00
New Revision: ef6014e764825753293fabf65c92afe79ed402cd
URL: https://github.com/llvm/llvm-project/commit/ef6014e764825753293fabf65c92afe79ed402cd
DIFF: https://github.com/llvm/llvm-project/commit/ef6014e764825753293fabf65c92afe79ed402cd.diff
LOG: [MLIR][LaunchFuncToLLVM] Remove typed pointer support (#70840)
This commit removes the typed pointer support from the LaunchFunc's
lowering to LLVM dialect. Typed pointers have been deprecated for a
while now and it's planned to soon remove them from the LLVM dialect.
Related PSA:
https://discourse.llvm.org/t/psa-removal-of-typed-pointers-from-the-llvm-dialect/74502
Added:
Modified:
mlir/include/mlir/Conversion/Passes.td
mlir/lib/Conversion/SPIRVToLLVM/ConvertLaunchFuncToLLVMCalls.cpp
Removed:
################################################################################
diff --git a/mlir/include/mlir/Conversion/Passes.td b/mlir/include/mlir/Conversion/Passes.td
index 036c9b0039779ab..2d504cd9192ad75 100644
--- a/mlir/include/mlir/Conversion/Passes.td
+++ b/mlir/include/mlir/Conversion/Passes.td
@@ -472,12 +472,6 @@ def LowerHostCodeToLLVMPass : Pass<"lower-host-to-llvm", "ModuleOp"> {
dialect, emitting C wrappers.
}];
- let options = [
- Option<"useOpaquePointers", "use-opaque-pointers", "bool",
- /*default=*/"true", "Generate LLVM IR using opaque pointers "
- "instead of typed pointers">
- ];
-
let dependentDialects = ["LLVM::LLVMDialect"];
}
diff --git a/mlir/lib/Conversion/SPIRVToLLVM/ConvertLaunchFuncToLLVMCalls.cpp b/mlir/lib/Conversion/SPIRVToLLVM/ConvertLaunchFuncToLLVMCalls.cpp
index 605c5b8b256ee74..0e9eb9799c3e0be 100644
--- a/mlir/lib/Conversion/SPIRVToLLVM/ConvertLaunchFuncToLLVMCalls.cpp
+++ b/mlir/lib/Conversion/SPIRVToLLVM/ConvertLaunchFuncToLLVMCalls.cpp
@@ -298,7 +298,6 @@ class LowerHostCodeToLLVM
// Specify options to lower to LLVM and pull in the conversion patterns.
LowerToLLVMOptions options(module.getContext());
- options.useOpaquePointers = useOpaquePointers;
auto *context = module.getContext();
RewritePatternSet patterns(context);
More information about the Mlir-commits
mailing list