[Mlir-commits] [mlir] [mlir][arith] Add ArithOpsInterfaces to mlir-generic-headers (PR #70862)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Oct 31 14:37:48 PDT 2023


https://github.com/anemet created https://github.com/llvm/llvm-project/pull/70862

This is achieved by calling add_mlir_interface.

The issue manifests as ArithOpsInterfaces.h.inc not being available when a pass includes something like MemRef.h which includes Arith.h.

Tested with check-mlir.

>From d12a83dcb6ab54c0c66d30571197722ebf763d54 Mon Sep 17 00:00:00 2001
From: Adam Nemet <anemet at apple.com>
Date: Tue, 31 Oct 2023 08:36:14 -0700
Subject: [PATCH] [mlir][arith] Add ArithOpsInterfaces to mlir-generic-headers

This is achieved by calling add_mlir_interface.

The issue manifests as ArithOpsInterfaces.h.inc not being available
when a pass includes somethihng like MemRef.h which includes
Arith.h.

Tested with check-mlir.
---
 mlir/include/mlir/Dialect/Arith/IR/CMakeLists.txt | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/mlir/include/mlir/Dialect/Arith/IR/CMakeLists.txt b/mlir/include/mlir/Dialect/Arith/IR/CMakeLists.txt
index 5cdde2edd50f1ea..a2f24bdd94444db 100644
--- a/mlir/include/mlir/Dialect/Arith/IR/CMakeLists.txt
+++ b/mlir/include/mlir/Dialect/Arith/IR/CMakeLists.txt
@@ -7,8 +7,4 @@ mlir_tablegen(ArithOpsAttributes.cpp.inc -gen-attrdef-defs
               -attrdefs-dialect=arith)
 add_mlir_dialect(ArithOps arith)
 add_mlir_doc(ArithOps ArithOps Dialects/ -gen-dialect-doc)
-
-set(LLVM_TARGET_DEFINITIONS ArithOpsInterfaces.td)
-mlir_tablegen(ArithOpsInterfaces.h.inc -gen-op-interface-decls)
-mlir_tablegen(ArithOpsInterfaces.cpp.inc -gen-op-interface-defs)
-add_public_tablegen_target(MLIRArithOpsInterfacesIncGen)
+add_mlir_interface(ArithOpsInterfaces)



More information about the Mlir-commits mailing list