[Mlir-commits] [mlir] [mlir][python] remove various caching mechanism (PR #70831)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Oct 31 12:57:43 PDT 2023


================
@@ -34,7 +34,6 @@ PYBIND11_MODULE(_mlir, m) {
           "append_dialect_search_prefix",
           [](PyGlobals &self, std::string moduleName) {
             self.getDialectSearchPrefixes().push_back(std::move(moduleName));
-            self.clearImportCache();
----------------
rkayaith wrote:

My interpretation is that this is to support:
1. `loadDialectModule("my_dialect")` - doesn't find module
2. `append_dialect_search_prefix("path/to/my_dialect")`
3. `loadDialectModule("my_dialect")` - finds module
 
So its not about reloading existing modules, just loading new ones. Without clearing `loadedDialectModules` you'd end up hitting the early exit in `loadDialectModule`.

https://github.com/llvm/llvm-project/pull/70831


More information about the Mlir-commits mailing list