[Mlir-commits] [mlir] [MLIR][LLVM] Infer export location scope from location, is possible (PR #70465)
    Tobias Gysi 
    llvmlistbot at llvm.org
       
    Sun Oct 29 01:15:33 PDT 2023
    
    
  
https://github.com/gysit approved this pull request.
LGTM!
I think if there are some comments that can be added that make this code a bit easier to digest then that may be helpful. Maybe something like "While the scope maybe null initially, it can be derived from a FusedLoc that has a scope attached". Somewhere at the beginning of the function could be helpful? 
https://github.com/llvm/llvm-project/pull/70465
    
    
More information about the Mlir-commits
mailing list