[Mlir-commits] [mlir] 8f9da1e - [mlir][ml_program] Add asm names for load (#70409)

[llvmlistbot at llvm.org]

Author: Jacques Pienaar
Date: 2023-10-27T09:36:50-07:00
New Revision: 8f9da1e4be69215c89f913766b7976bcc2e24ac2

URL: https://github.com/llvm/llvm-project/commit/8f9da1e4be69215c89f913766b7976bcc2e24ac2
DIFF: https://github.com/llvm/llvm-project/commit/8f9da1e4be69215c89f913766b7976bcc2e24ac2.diff

LOG: [mlir][ml_program] Add asm names for load (#70409)

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td b/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td
index f1d4972f48cff64..fd213824b30ca45 100644
--- a/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td
+++ b/mlir/include/mlir/Dialect/MLProgram/IR/MLProgramOps.td
@@ -16,6 +16,7 @@ include "mlir/Interfaces/CallInterfaces.td"
 include "mlir/Interfaces/ControlFlowInterfaces.td"
 include "mlir/Interfaces/SideEffectInterfaces.td"
 include "mlir/Interfaces/FunctionInterfaces.td"
+include "mlir/IR/OpAsmInterface.td"
 include "mlir/IR/RegionKindInterface.td"
 include "mlir/IR/SymbolInterfaces.td"
 
@@ -153,6 +154,7 @@ def MLProgram_GlobalOp : MLProgram_Op<"global", [
 //===----------------------------------------------------------------------===//
 
 def MLProgram_GlobalLoadOp : MLProgram_Op<"global_load", [
+    DeclareOpInterfaceMethods<OpAsmOpInterface, ["getAsmResultNames"]>,
     DeclareOpInterfaceMethods<SymbolUserOpInterface>
   ]> {
   let summary = "Direct load of a mutable value from a global";
@@ -190,6 +192,13 @@ def MLProgram_GlobalLoadOp : MLProgram_Op<"global_load", [
     /// Gets the corresponding GlobalOp (or nullptr).
     GlobalOp getGlobalOp(SymbolTableCollection &symbolTable);
   }];
+
+  let extraClassDefinition = [{
+    void $cppClass::getAsmResultNames(
+        function_ref<void(::mlir::Value, ::llvm::StringRef)> setNameFn) {
+      setNameFn(getResult(), getGlobal().getLeafReference());
+    }
+  }];
 }
 
 //===----------------------------------------------------------------------===//
@@ -198,6 +207,7 @@ def MLProgram_GlobalLoadOp : MLProgram_Op<"global_load", [
 
 def MLProgram_GlobalLoadConstOp : MLProgram_Op<"global_load_const", [
     Pure,
+    DeclareOpInterfaceMethods<OpAsmOpInterface, ["getAsmResultNames"]>,
     DeclareOpInterfaceMethods<SymbolUserOpInterface>
   ]> {
   let summary = "Direct load a constant value from a global";
@@ -229,6 +239,13 @@ def MLProgram_GlobalLoadConstOp : MLProgram_Op<"global_load_const", [
     /// Gets the corresponding GlobalOp (or nullptr).
     GlobalOp getGlobalOp(SymbolTableCollection &symbolTable);
   }];
+
+  let extraClassDefinition = [{
+    void $cppClass::getAsmResultNames(
+      function_ref<void(::mlir::Value, ::llvm::StringRef)> setNameFn) {
+        setNameFn(getResult(), getGlobal().getLeafReference());
+    }
+  }];
 }
 
 //===----------------------------------------------------------------------===//