[Mlir-commits] [mlir] [mlir][vector] Update v.contract -> v.outerproduct tests (1/N) (PR #70379)

Andrzej Warzyński llvmlistbot at llvm.org
Fri Oct 27 04:57:11 PDT 2023


banach-space wrote:

> These mostly make sense to me, I think you've got all the duplicates (but I find them hard to spot 😅)

Yeah, that's why I have been updating:
```cpp
#matvec_accesses_1 = [
  affine_map<(i, j) -> (i, j)>,
  affine_map<(i, j) -> (j)>,
  affine_map<(i, j) -> (i)>
]
```

to
```cpp
#matvec_accesses_1 = [
  affine_map<(m, k) -> (m, k)>,
  affine_map<(m, k) -> (k)>,
  affine_map<(m, k) -> (m)>
]
```

so that all examples are consistent. Then it's easy to spot duplicates.

I've updated the summary to capture the changes from the fixup and will merge this shortly. Thanks for taking a look!

https://github.com/llvm/llvm-project/pull/70379


More information about the Mlir-commits mailing list