[Mlir-commits] [mlir] [mlir] NFC: Clarify documentation on InferShapedTypeOpInterface::inferReturnTypeComponents (PR #70350)

Mehdi Amini llvmlistbot at llvm.org
Thu Oct 26 12:53:15 PDT 2023


================
@@ -142,6 +142,9 @@ def InferShapedTypeOpInterface : OpInterface<"InferShapedTypeOpInterface"> {
       Unknown (e.g., unranked) shape and nullptrs for element type and attribute
       may be returned by this function while returning success. E.g., partial
       population of components is not error condition.
+
+      Be aware that this method is supposed to be called with valid arguments,
+      e.g., operands are verified, or it may result in an undefined behavior.
----------------
joker-eph wrote:

This is the opposite of my understanding of what @jpienaar wrote on Discord. This method can be called by the verifier and so can't assume anything about the operands.

https://github.com/llvm/llvm-project/pull/70350


More information about the Mlir-commits mailing list