[Mlir-commits] [mlir] [MLIR] SPIRV Target Attribute (PR #69949)

[Fabian Mora]

fabianmcg wrote:

This patch LGTM! I'll approve once the builds have completed.

> Without those changes, mlir-cpu-runner will see spirv.target attribute in the input which is part of SPIRV dialect. And since SPIRV dialect is not registered, mlir-cpu-runner throws an error.

Did you try just registering the dialect instead of adding a translation? I'm still unsure if adding a translation to LLVM is needed, as the error is probably only happening during parsing? But I guess we can have this conversation on the next PR.



https://github.com/llvm/llvm-project/pull/69949