[Mlir-commits] [mlir] [OpenMP][MLIR] OMPEarlyOutliningPass removal (PR #67319)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Oct 26 00:46:52 PDT 2023
agozillon wrote:
The patch series LGTM so far, the only concern I have (which is very minor) is the map type and capture type we give the bounds information when we generate map_info's for them, but I think that's something we can adjust in future patches if we have any problems as I am not sure myself what they should be mapped as currently. Provided this patch series doesn't break any existing runtime tests we have I'm happy with it.
I've also added one comment relating to manipulating the capture type of implicits based on how Clang handles it currently, we can add it in this patch series or later I don't mind too much, it just seemed like a good possible addition.
https://github.com/llvm/llvm-project/pull/67319
More information about the Mlir-commits
mailing list