[Mlir-commits] [mlir] 9d712d2 - [MLIR][pass registry] show overlapping pass pipeline name (#70167)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Oct 25 09:28:55 PDT 2023


Author: Maksim Levental
Date: 2023-10-25T11:28:50-05:00
New Revision: 9d712d2dfbbf1d68f8a86685debe51bd35474244

URL: https://github.com/llvm/llvm-project/commit/9d712d2dfbbf1d68f8a86685debe51bd35474244
DIFF: https://github.com/llvm/llvm-project/commit/9d712d2dfbbf1d68f8a86685debe51bd35474244.diff

LOG: [MLIR][pass registry] show overlapping pass pipeline name (#70167)

Similar to https://github.com/llvm/llvm-project/pull/70108.

Added: 
    

Modified: 
    mlir/lib/Pass/PassRegistry.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Pass/PassRegistry.cpp b/mlir/lib/Pass/PassRegistry.cpp
index e3ea5704f61d16a..b0c314369190a40 100644
--- a/mlir/lib/Pass/PassRegistry.cpp
+++ b/mlir/lib/Pass/PassRegistry.cpp
@@ -6,12 +6,10 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include <optional>
-#include <utility>
+#include "mlir/Pass/PassRegistry.h"
 
 #include "mlir/Pass/Pass.h"
 #include "mlir/Pass/PassManager.h"
-#include "mlir/Pass/PassRegistry.h"
 #include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/ScopeExit.h"
 #include "llvm/Support/Format.h"
@@ -19,6 +17,9 @@
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Support/SourceMgr.h"
 
+#include <optional>
+#include <utility>
+
 using namespace mlir;
 using namespace detail;
 
@@ -99,7 +100,10 @@ void mlir::registerPassPipeline(
   PassPipelineInfo pipelineInfo(arg, description, function,
                                 std::move(optHandler));
   bool inserted = passPipelineRegistry->try_emplace(arg, pipelineInfo).second;
-  assert(inserted && "Pass pipeline registered multiple times");
+#ifndef NDEBUG
+  if (!inserted)
+    report_fatal_error("Pass pipeline " + arg + " registered multiple times");
+#endif
   (void)inserted;
 }
 


        


More information about the Mlir-commits mailing list