[Mlir-commits] [mlir] [NFC] Make AggregateOpInterface part of mlir:: instead of linalg:: (PR #70089)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> > The change looks fine but what is your use case?
> > Also, we may want to also move the `DecomposeInterfaceOp` transform operation in the generic part.
> 
> Hi @dcaballe
> 
> So, the use case occurs in IREE where we have operations from `LinalgExt` like `Attention`, `WinogradInputTransformOp` and `WinogradOutputTransformOp` which we decompose into finer set of operations. The cleaner way to do that would be for them to adhere to `AggregateOpInterface`'s contract and invoke their decompositions via `decomposeOperation`. But since `AggregateOpInterface` is tightly bound to `linalg` currently, including it straightaway is not possible - so we're trying to move this at a generic namespace for anyone to be able to implement their operation's decomposition using this interface and therefore also reduce the extra number of decomposition passes one may require.
> 
> Also regarding the `DecomposeInterfaceOp` - can we take it up in a subsequent revision? A quick search shows that `applyToOne` has far too many users and perhaps it'd be better if we address it in a separate PR.
> 
> CC: @MaheshRavishankar

@qcolombet  see comment above, but I think its more about, this doesnt need to be in Linalg, so avoiding unnecessary dependency on Linalg by moving this out.
W.R.T the transform dialect op, would be great if we could do it as a follow up.

https://github.com/llvm/llvm-project/pull/70089