[Mlir-commits] [mlir] [mlir][ArmSVE] Add `-arm-sve-legalize-vector-storage` pass (PR #68794)

[Andrzej Warzyński]

https://github.com/banach-space commented:

The overall logic makes perfect sense to me, thanks a ton Ben!

I don't really have any major suggestions regarding the implementation, but I think that it would be good to clarify a few key things in comments:
* what's "legal" and what's "illegal" in this context and why ?
* what's the definition of `svbool_t`?
* what about predicates like `vector<[7]xi1>`?

It would also be good to mention somewhere that `__arm_sve_legalize_vector_storage__` should only be present during the legalizer pass (i.e. it's the pass that creates tagged ops and then consumes them).

Hope this makes sense :)

https://github.com/llvm/llvm-project/pull/68794