[Mlir-commits] [mlir] 8875f78 - [mlir] Change default NVVM compilation to `fatbin` from `bin` (#70052)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Oct 24 07:56:20 PDT 2023


Author: Guray Ozen
Date: 2023-10-24T16:56:15+02:00
New Revision: 8875f78b5d11688f2cabd916b3e04552659c5e17

URL: https://github.com/llvm/llvm-project/commit/8875f78b5d11688f2cabd916b3e04552659c5e17
DIFF: https://github.com/llvm/llvm-project/commit/8875f78b5d11688f2cabd916b3e04552659c5e17.diff

LOG: [mlir] Change default NVVM compilation  to `fatbin` from `bin` (#70052)

Change the NVVM assembly to `fatbin` as it is executable for multiple
architectures. Using `bin` caused test errors at runtime in the test
systems.

Added: 
    

Modified: 
    mlir/test/lib/Dialect/GPU/TestLowerToNVVM.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/test/lib/Dialect/GPU/TestLowerToNVVM.cpp b/mlir/test/lib/Dialect/GPU/TestLowerToNVVM.cpp
index c4cc0d5ae38d9be..ed7634fbecf49fd 100644
--- a/mlir/test/lib/Dialect/GPU/TestLowerToNVVM.cpp
+++ b/mlir/test/lib/Dialect/GPU/TestLowerToNVVM.cpp
@@ -60,7 +60,7 @@ struct TestLowerToNVVMOptions
   PassOptions::Option<std::string> cubinFormat{
       *this, "cubin-format",
       llvm::cl::desc("Compilation format to use to serialize to cubin."),
-      llvm::cl::init("bin")};
+      llvm::cl::init("fatbin")};
   PassOptions::Option<int> optLevel{
       *this, "opt-level",
       llvm::cl::desc("Optimization level for NVVM compilation"),
@@ -156,4 +156,4 @@ void registerTestLowerToNVVM() {
 }
 } // namespace test
 } // namespace mlir
-#endif // MLIR_CUDA_CONVERSIONS_ENABLED
+#endif // MLIR_CUDA_CONVERSIONS_ENABLED
\ No newline at end of file


        


More information about the Mlir-commits mailing list