[Mlir-commits] [mlir] [mlir] Change default NVVM compilation to `fatbin` from `bin` (PR #70052)

[Guray Ozen]

https://github.com/grypp created https://github.com/llvm/llvm-project/pull/70052

Change the NVVM assembly to `fatbin` as it is executable for multiple architectures. Using `bin` caused test errors at runtime in the test systems.

>From 2a2a4c42e86dd46662b3afdaa0531f9cbc34ff18 Mon Sep 17 00:00:00 2001
From: Guray Ozen <guray.ozen at gmail.com>
Date: Tue, 24 Oct 2023 16:40:48 +0200
Subject: [PATCH] [mlir] Change default NVVM compilation  to `fatbin` from
 `bin`

Change the NVVM assembly to `fatbin` as it is executable for multiple architectures. Using `bin` caused test errors at runtime in the test systems.
---
 mlir/test/lib/Dialect/GPU/TestLowerToNVVM.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mlir/test/lib/Dialect/GPU/TestLowerToNVVM.cpp b/mlir/test/lib/Dialect/GPU/TestLowerToNVVM.cpp
index c4cc0d5ae38d9be..ed7634fbecf49fd 100644
--- a/mlir/test/lib/Dialect/GPU/TestLowerToNVVM.cpp
+++ b/mlir/test/lib/Dialect/GPU/TestLowerToNVVM.cpp
@@ -60,7 +60,7 @@ struct TestLowerToNVVMOptions
   PassOptions::Option<std::string> cubinFormat{
       *this, "cubin-format",
       llvm::cl::desc("Compilation format to use to serialize to cubin."),
-      llvm::cl::init("bin")};
+      llvm::cl::init("fatbin")};
   PassOptions::Option<int> optLevel{
       *this, "opt-level",
       llvm::cl::desc("Optimization level for NVVM compilation"),
@@ -156,4 +156,4 @@ void registerTestLowerToNVVM() {
 }
 } // namespace test
 } // namespace mlir
-#endif // MLIR_CUDA_CONVERSIONS_ENABLED
+#endif // MLIR_CUDA_CONVERSIONS_ENABLED
\ No newline at end of file