[Mlir-commits] [mlir] [mlir][python] Clear PyOperations instead of invalidating them. (PR #70044)

[Ingo Müller]

ingomueller-net wrote:

> Ya this is good. I think I was implicitly relying on a [`clearLiveOperations`](https://github.com/llvm/llvm-project/blob/f364a7a8b4915409ea32df4483320ad40a378242/mlir/lib/Bindings/Python/IRModule.h#L210) to happen after the pass but now I don't know why because as far I can tell (from my phone...) that function isn't actually called anywhere. Can you double check and if it's not then remove it.

Yeah, no, it's not called. It is also not precise enough: it would invalidate (and clear) *all* operations but with your original commit you are able to preserve the root op of the pass.

https://github.com/llvm/llvm-project/pull/70044