[Mlir-commits] [mlir] [mlir][python] remove mixins (PR #68853)

Ingo Müller llvmlistbot at llvm.org
Tue Oct 24 00:42:23 PDT 2023


ingomueller-net wrote:

> As for handling changes to ODS op specification, this doesn't make it any worse. In the existing approach, we would have also needed to update the mixin classes when ODS changed (there have been several cases recently). I think the best way to guard against this is to keep improving the generated API (e.g., generate overloads) so that the amount of handwritten builders becomes minimal.

I agree that removing/reducing the need to write mix-ins/extensions should remove/reduce the test surface and thus this issue. For the remainder, I thought about a way to test this some time ago: https://reviews.llvm.org/D159100. I can revive that if there is interest/consensus.

https://github.com/llvm/llvm-project/pull/68853


More information about the Mlir-commits mailing list