[Mlir-commits] [mlir] [Tosa] Fix TosaValidation for FuncOp (PR #69997)

Mehdi Amini llvmlistbot at llvm.org
Mon Oct 23 22:17:44 PDT 2023


================
@@ -526,8 +527,8 @@ void TosaValidation::runOnOperation() {
     if (failed(applyLevelCheck(op)))
       signalPassFailure();
 
-    // do variable type checks
-    if (failed(applyVariableCheck(op)))
+    // do variable type checks iff topOp is a ModuleOp
+    if (isModule && failed(applyVariableCheck(op)))
----------------
joker-eph wrote:

That makes the validation behavior different depending on how it is scheduled: seems like something easy to misconfigure? What is the motivation to allow this "partial validation"?


https://github.com/llvm/llvm-project/pull/69997


More information about the Mlir-commits mailing list