[Mlir-commits] [mlir] [MLIR] SPIRV Target Attribute (PR #69949)

[Fabian Mora]

fabianmcg wrote:

@silee2 I'll take a closer look later, at first glance it looks like everything is there.

Just one quick question, can you describe the next PR a bit more? Because, you shouldn't need to make the target LLVMIR aware, as  the binary embedding is mostly dialect agnostic, so there shouldn't be an issue with `SPIRVTargetAttr` not having a translation to LLVM.
>From what I remember from the original PR the only other modification needed is changing how the kernel is launched, and that change must be done in [Target/LLVMIR/Dialect/GPU/SelectObjectAttr.cpp ](https://github.com/llvm/llvm-project/blob/main/mlir/lib/Target/LLVMIR/Dialect/GPU/SelectObjectAttr.cpp)

https://github.com/llvm/llvm-project/pull/69949