[Mlir-commits] [mlir] [mlir][VectorOps] Support string literals in `vector.print` (PR #68695)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Oct 23 07:56:49 PDT 2023


================
@@ -158,7 +158,8 @@ extern "C" void printMemrefC64(int64_t rank, void *ptr) {
   _mlir_ciface_printMemrefC64(&descriptor);
 }
 
-extern "C" void printCString(char *str) { printf("%s", str); }
+/// Deprecated. This should be unified with printString from CRunnerUtils.
+extern "C" void printCString(char *str) { fputs(str, stdout); }
----------------
banach-space wrote:

[nit] I would just skip these changes altoghether.

https://github.com/llvm/llvm-project/pull/68695


More information about the Mlir-commits mailing list