[Mlir-commits] [mlir] [mlir][tosa] Fix crash in inferReturnTypes for ReduceOps (PR #69843)

Felix Schneider llvmlistbot at llvm.org
Mon Oct 23 05:26:50 PDT 2023


ubfx wrote:

>my assumption would be that an error should be triggered if the `axis` parameter is `>=` than the input rank. Find it cleaner with well defined preconditions.

Makes sense, we could implement this as a verifier for the Op? Then we wouldn't emit the error in the shape inference pass itself, but in the verification afterwards.

https://github.com/llvm/llvm-project/pull/69843


More information about the Mlir-commits mailing list