[Mlir-commits] [mlir] [mlir][VectorOps] Support string literals in `vector.print` (PR #68695)

Benjamin Maxwell llvmlistbot at llvm.org
Mon Oct 23 04:06:29 PDT 2023


MacDue wrote:

> Perhaps we should just focus on vector.print and skip cf.assert for now? Would that simplify things?

We can't skip `cf.assert` as this is shared code, but I've now reworked things so you can specify the runtime function to use. `cf.assert` will now keep using `puts()` and `vector.print` will use a new `printString()` function (which is defined only in CRunnerUtils). 

---

`printCString()` should be removed in a later patch (and uses updated to use `vector.print str` or `printString()` directly)

https://github.com/llvm/llvm-project/pull/68695


More information about the Mlir-commits mailing list