[Mlir-commits] [mlir] [mlir][VectorOps] Support string literals in `vector.print` (PR #68695)

[Andrzej Warzyński]

banach-space wrote:

> I've also defined an implementation in RunnerUtils since this is shared with `cf.assert

Hi Ben, I think that we should avoid defining the same symbol both in `RunnerUtils` and `CRunnerUtils`. I know that the linker won't complain (IIRC, I will just use the first definition that it encounters). However, once the definitions in two libraries diverge, people might see different behavior depending on the order in which they list these runtime libraries. That would be undesirable. 

Perhaps we should just focus on `vector.print` and skip `cf.assert` for now? Would that simplify things?

https://github.com/llvm/llvm-project/pull/68695