[Mlir-commits] [mlir] NFC. Move out and expose affine expression simplification utility out of AffineOps lib (PR #69813)

Kunwar Grover llvmlistbot at llvm.org
Sat Oct 21 13:51:47 PDT 2023


Groverkss wrote:

I'm not sure I understand why something like FlatLinearConstraints would call out to this IR method instead of Presburger methods to do the same.

Im not very supportive of doing such analysis on AffineMap. In my view, anything that requires a flattening of the AffineMap should be done be done on the flattened form, i.e. to get the bounds, first flatten it and then use Presburger methods to get these bounds (can be restricted to fast checks only). I do not have strong opinions on this, and would like to hear what others think.

https://github.com/llvm/llvm-project/pull/69813


More information about the Mlir-commits mailing list