[Mlir-commits] [mlir] [mlir][sparse] fix stack overflow due to alloca instruction inside loops (PR #69765)

[Oleksandr Alex Zinenko]

ftynse wrote:

Ah, the infamous allocation-in-the-loop problem. I do _not_ think we should remove the trait from `scf.for`. The fact that the lowering doesn't do stack save/restore doesn't mean that the semantics of the op is different. Semantics are not defined by lowerings, and the lowering may be incorrect. I remember we had very long and inconclusive discussions on whether this lowering should insert stack save/restore. Even if we did remove the trait, it absolutely should not happen in a change tagged "mlir, sparse, fix <...>".

https://github.com/llvm/llvm-project/pull/69765