[Mlir-commits] [mlir] [mlir][linalg] Add TransposeConv2D Pass (PR #68567)
Crefeda Rodrigues
llvmlistbot at llvm.org
Fri Oct 20 08:19:40 PDT 2023
cfRod wrote:
> > Could you also add an integration test similar to https://github.com/llvm/llvm-project/blob/main/mlir/test/Integration/Dialect/Linalg/CPU/test-conv-2d-nhwc-hwcf-call.mlir ?
>
> Sure, I'm happy to add a test, although I'm not sure if this is testing the transformation or the nhwc-fhwc conv2d operation itself? I see we don't have tests for that convolution channel but it existed before this PR.
Right, it is testing the conv2d operation itself but I was thinking in the lines of testing the transformation. For now, I think you can leave the integration test for another patch.
https://github.com/llvm/llvm-project/pull/68567
More information about the Mlir-commits
mailing list