[Mlir-commits] [mlir] [mlir][transform] Handle multiple library preloading passes (PR #69320)
Ingo Müller
llvmlistbot at llvm.org
Fri Oct 20 03:33:56 PDT 2023
================
@@ -315,6 +315,62 @@ class BuildOnly : public DerivedTy {
BuildOnly() : DerivedTy(/*buildOnly=*/true) {}
};
+namespace detail {
----------------
ingomueller-net wrote:
Yep, makes sense. I realized that I only have to move the `mergeSymbolsInto` function (and related static functions). The remaining ones (for expanding paths etc) are arguably more related to the interpreter pass than this one, so I am leaving them where they are.
For now, I am calling the files `Utils.h`/`Utils.cpp`. All other files are called `TransformSomething.xxx` -- should I rename the new files to `TransformUtils.xxx` as well to follow that scheme?
https://github.com/llvm/llvm-project/pull/69320
More information about the Mlir-commits
mailing list